[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 18:15:58 PDT 2018


echristo added a comment.

Hi Joerg,

In https://reviews.llvm.org/D28791#671326, @joerg wrote:

> You are wrong on (1), (2) and (3). But I am tired of this discussion. My objection stands. This is not a functional implementation for anything but a very narrow focus. There are much more complete implementations around. This creates more problems than it solves.


This is not a productive source of discussion. What path forward would you like here - saying that external projects have more complete implementations is also not a workable path forward. In particular, this could be a very good solution for platforms that aren't yours and provide a path forward for other platforms.

If you could be specific: what are you asking for this patch to do differently?

Thanks!

-eric


Repository:
  rL LLVM

https://reviews.llvm.org/D28791





More information about the llvm-commits mailing list