[PATCH] D53909: ADT/STLExtras: Introduce llvm::empty(); NFC

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 16:50:29 PDT 2018


MatzeB updated this revision to Diff 171837.
MatzeB added a comment.

- Add a simple unittest
- Go with the adl_begin() == adl_end() implementation for now. We can always switch to more fine grained overloading when we actually deem it necessary for performance. And after all we will probably just replace it with `std::empty()` anyway once we use C++17 in llvm.


Repository:
  rL LLVM

https://reviews.llvm.org/D53909

Files:
  include/llvm/ADT/STLExtras.h
  lib/Analysis/LazyCallGraph.cpp
  lib/CodeGen/GlobalISel/InstructionSelector.cpp
  lib/CodeGen/GlobalISel/LegalizerInfo.cpp
  lib/CodeGen/GlobalISel/RegBankSelect.cpp
  lib/CodeGen/GlobalISel/RegisterBankInfo.cpp
  lib/ExecutionEngine/Orc/ExecutionUtils.cpp
  lib/IR/DebugInfo.cpp
  lib/Transforms/IPO/PartialInlining.cpp
  lib/Transforms/Scalar/NewGVN.cpp
  lib/Transforms/Utils/PredicateInfo.cpp
  lib/Transforms/Utils/SimplifyCFG.cpp
  unittests/ADT/STLExtrasTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53909.171837.patch
Type: text/x-patch
Size: 7951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181030/a5d81688/attachment.bin>


More information about the llvm-commits mailing list