[PATCH] D53905: [ELF] Refactor TLS layout TargetInfo config. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 16:14:26 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/InputSection.cpp:572-573
+  // target-specific adjustment to produce a thread-pointer-relative offset.
+  switch (Target->TlsLayout) {
+    case TlsLayoutKind::FixedOffset:
+      return Target->TlsTpOffset;
----------------
I don't think you need to define TlsLayoutKind. I'd just dispatch based on `Config->EMachine` in this function.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53905





More information about the llvm-commits mailing list