[PATCH] D50330: [RFC] Implement out-of-process allocator enumeration for macOS

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

Sorry, this isn't any better than the previous version. 
Please understand my position: this is the core code for all the existing sanitizers, scudo, and the new hwasan, 
we are planing to have this code in production (in fact, we already have it in production in many places). 
There is no way we can maintain code with so much extra stuff in it. The change has to be less intrusive.

>> Just to note at our discussions at LLVMDev you wanted the template type (in this case what I call ObjectView) to an allocator parameter. I have not done this because I discovered this is impossible (when ObjectView is templated on the type of the object it is representing) because you end up with mutually recursive types. I.e.
>>  ObjectView<Allocator<Params< ObjectView<Allocator<Params< ... > > > > > >

I don't understand this. Let's take some specific class, e.g. SizeClassAllocator64, 
and see why ObjectView can't be made part of "Params".

Is it possible to make this change in several iterations where you start from introducing one more template parameter (ObjectView?) that does very little, 
then we can iterate extending it.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50330