[PATCH] D53594: [GlobalISel] Introduce G_BUILD_VECTOR and G_CONCAT_VECTOR opcodes

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 11:49:04 PDT 2018


aditya_nandakumar added a comment.

In https://reviews.llvm.org/D53594#1280811, @qcolombet wrote:

> Thanks @aditya_nandakumar for the context.
>
> I understand where you're coming from.
>
> What I meant is that I would rather have one opcode of build_vector and one for build_vector with trunc. The rationale is that it makes it clear what you want to achieve and it makes for a stronger type verifier.


+1 for having explicit opcodes for truncation.


Repository:
  rL LLVM

https://reviews.llvm.org/D53594





More information about the llvm-commits mailing list