[PATCH] D53846: Check shouldReduceLoadWidth from SimplifySetCC

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 16:04:40 PDT 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:676-677
+      AMDGPUInstrInfo::isUniformMMO(MN->getMemOperand()) &&
+      (AS == AMDGPUAS::CONSTANT_ADDRESS ||
+       AS == AMDGPUAS::CONSTANT_ADDRESS_32BIT))
+    return false;
----------------
arsenm wrote:
> What about the load from uniform global that uses a scalar load?
Also the address space check should go before the isUNiformMMO


https://reviews.llvm.org/D53846





More information about the llvm-commits mailing list