[PATCH] D53803: [llvm-objdump] add support for '--syms' as an alias of -t (PR39406)

[Xing via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 171670.

https://reviews.llvm.org/D53803

Files:
  test/tools/llvm-objdump/symbol-table-elf.test
  tools/llvm-objdump/llvm-objdump.cpp


Index: tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- tools/llvm-objdump/llvm-objdump.cpp
+++ tools/llvm-objdump/llvm-objdump.cpp
@@ -118,8 +118,9 @@
 cl::opt<bool>
 llvm::SectionContents("s", cl::desc("Display the content of each section"));
 
-cl::opt<bool>
-llvm::SymbolTable("t", cl::desc("Display the symbol table"));
+cl::opt<bool> llvm::SymbolTable("syms", cl::desc("Display the symbol table"));
+static cl::alias SymbolTableShort("t", cl::desc("Alias for --syms"),
+                                  cl::aliasopt(llvm::SymbolTable));
 
 cl::opt<bool>
 llvm::ExportsTrie("exports-trie", cl::desc("Display mach-o exported symbols"));
Index: test/tools/llvm-objdump/symbol-table-elf.test
===================================================================
--- test/tools/llvm-objdump/symbol-table-elf.test
+++ test/tools/llvm-objdump/symbol-table-elf.test
@@ -0,0 +1,47 @@
+# RUN: yaml2obj %s > %t
+# RUN: llvm-objdump --syms %t | FileCheck %s
+# RUN: llvm-objdump -t     %t | FileCheck %s
+
+# CHECK:      SYMBOL TABLE:
+# CHECK-NEXT: 0000000000000000         *UND*     00000000
+# CHECK-NEXT: 0000000000001004 l     F .text     00000000 lfoo
+# CHECK-NEXT: 0000000000001008 l       .text     00000000 lbar
+# CHECK-NEXT: 0000000000001004 g     F .text     00000000 foo
+# CHECK-NEXT: 0000000000001008 g       .text     00000000 bar
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_EXEC
+  Machine:         EM_X86_64
+Sections:
+  - Name:            .bss
+    Type:            SHT_NOBITS
+    Flags:           [ SHF_ALLOC ]
+    AddressAlign:    0x0000000000000010
+    Size:            64
+  - Name:            .text
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    AddressAlign:    0x0000000000000010
+    Content:         "00000000"
+Symbols:
+   Global:
+     - Name:     foo
+       Type:     STT_FUNC
+       Section:  .text
+       Value:    0x1004
+     - Name:     bar
+       Type:     STT_OBJECT
+       Section:  .text
+       Value:    0x1008
+   Local:
+     - Name:     lfoo
+       Type:     STT_FUNC
+       Section:  .text
+       Value:    0x1004
+     - Name:     lbar
+       Type:     STT_OBJECT
+       Section:  .text
+       Value:    0x1008


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53803.171670.patch
Type: text/x-patch
Size: 2334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181030/fae23dbd/attachment-0001.bin>