[PATCH] D53821: [ELF][PPC64]Workaround bogus Visual Studio build warning

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 03:58:47 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL345579: [ELF][PPC64]Workaround bogus Visual Studio build warning (authored by jhenderson, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53821?vs=171530&id=171662#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53821

Files:
  lld/trunk/ELF/Arch/PPC64.cpp


Index: lld/trunk/ELF/Arch/PPC64.cpp
===================================================================
--- lld/trunk/ELF/Arch/PPC64.cpp
+++ lld/trunk/ELF/Arch/PPC64.cpp
@@ -849,7 +849,8 @@
   int32_t StackFrameSize = (HiImm * 65536) + LoImm;
   // Check that the adjusted size doesn't overflow what we can represent with 2
   // instructions.
-  if (StackFrameSize < -2147483648 + Config->SplitStackAdjustSize) {
+  if (StackFrameSize <
+      std::numeric_limits<int32_t>::min() + Config->SplitStackAdjustSize) {
     error(getErrorLocation(Loc) + "split-stack prologue adjustment overflows");
     return false;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53821.171662.patch
Type: text/x-patch
Size: 620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181030/088a6e2e/attachment.bin>


More information about the llvm-commits mailing list