[PATCH] D53782: [llvm-objcopy] Don't apply --localize flags to common symbols

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a subscriber: alexshap.
jakehehrlich added a comment.

Ah fair. That looks like many cases we've unfortunately seen before (see
SHF_LINK and SHF_COMPRESSED) that are not always respected (and thus we
must support the old case as well). So disregard my comment about using the
type. That's what I get for blindly reading the spec.

l'm still waiting to hear back from Roland about the sensibilities of this
but what's sensible probably doesn't matter the more I think about it. I'll
give a +2 later tomorrow if I can't think of a better way to resolve this
in a practical manner. As of yet this seems like the best option to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D53782