[PATCH] D53275: [Power9] Exploit power9 new instruction setb

[Kewen Lin via Phabricator via llvm-commits]

jedilyn marked 4 inline comments as done.
jedilyn added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:776
                        "maddld $RT, $RA, $RB, $RC", IIC_IntMulHD, []>, isPPC64;
-def SETB : XForm_44<31, 128, (outs g8rc:$RT), (ins crrc:$BFA),
-                     "setb $RT, $BFA", IIC_IntGeneral>, isPPC64;
+def SETB : XForm_44<31, 128, (outs gprc:$RT), (ins crrc:$BFA),
+                     "setb $RT, $BFA", IIC_IntGeneral>, isPPC64;
----------------
jedilyn wrote:
> nemanjai wrote:
> > As a matter of custom, we put these into `PPCInstrInfo.td`.
> I was originally intended to move SETB to `PPCInstrInfo.td`, but I found this instruction is flagged as PPC64 only. I searched around in `PPCInstrInfo.td` and can't find any similar cases, so I didn't think it's a good idea to move one 64bit only instruction out of `PPCInstr64Bit.td`.
Does it make sense to still keep it in `PPCInstr64Bit.td`?


Repository:
  rL LLVM

https://reviews.llvm.org/D53275