[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 17:45:23 PDT 2018


rnk added a comment.
Herald added a subscriber: JDevlieghere.

I was reviewing the records that msvc emits that clang does not, and I noticed this again.

Here's a thought. Why are we putting this on the compile unit in the first place? Why not use a global named metadata node? Most of the complexity in this patch is from going through DICompileUnit, when we can just claim a global named metadata node for the output object file. It could probably even point to a DIFile so we can preserve some information about whether the path is relative.


https://reviews.llvm.org/D43002





More information about the llvm-commits mailing list