[PATCH] D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling)

[Eric Christopher via llvm-commits]

On Mon, Oct 29, 2018, 4:08 PM Wolfgang Pieb via Phabricator <
reviews at reviews.llvm.org> wrote:

> wolfgangp added inline comments.
>
>
> ================
> Comment at: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFListTable.h:165
> +  /// True if this list is located in a split-DWARF (dwo or dwp) file.
> +  bool isDWO;
>    /// This string is displayed as a heading before the list is dumped
> ----------------
> dblaikie wrote:
> > echristo wrote:
> > > dblaikie wrote:
> > > > echristo wrote:
> > > > > Trying to figure out a way around isDWO as a boolean argument and
> data member would be great.
> > > > Avoiding it being a boolean, or avoiding having the same name for an
> argument and data member at the same time?
> > > The former. I'd like to avoid the boolean existing if we can avoid it,
> and definitely as an argument to the constructor as well.
> > Ah, OK. In the "boolean arguments are hard to read" (eg: replace them
> with an enum) or the "this is extra state/information that this part of the
> code might, hopefully, not need to know"?
> Yeah, it looks like it's always available from the context. If all goes
> well with this patch I'll try to do this as a follow-on if that's OK with
> you.
>
Absolutely! Thanks!

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181029/d98bd4b1/attachment.html>