[PATCH] D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling)

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFListTable.h:165
+  /// True if this list is located in a split-DWARF (dwo or dwp) file.
+  bool isDWO;
   /// This string is displayed as a heading before the list is dumped
----------------
echristo wrote:
> dblaikie wrote:
> > echristo wrote:
> > > Trying to figure out a way around isDWO as a boolean argument and data member would be great.
> > Avoiding it being a boolean, or avoiding having the same name for an argument and data member at the same time?
> The former. I'd like to avoid the boolean existing if we can avoid it, and definitely as an argument to the constructor as well. 
Ah, OK. In the "boolean arguments are hard to read" (eg: replace them with an enum) or the "this is extra state/information that this part of the code might, hopefully, not need to know"?


Repository:
  rL LLVM

https://reviews.llvm.org/D53545