[PATCH] D53760: [SelectionDAG] Add FoldBUILD_VECTOR to simplify new BUILD_VECTOR nodes

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 13:07:22 PDT 2018


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3834
+  }
+  if (IsIdentity && IdentitySrc)
+    return IdentitySrc;
----------------
RKSimon wrote:
> efriedma wrote:
> > Is it actually possible for IdentitySrc to be null here?  Even if it is, does it make a difference?
> No it makes no difference - not sure if its even worth an assert?
Not worth an assert IMO.


Repository:
  rL LLVM

https://reviews.llvm.org/D53760





More information about the llvm-commits mailing list