[PATCH] D52999: [FileCheck] Annotate input dump

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 10:39:54 PDT 2018


jdenny added a comment.

In https://reviews.llvm.org/D52999#1271097, @jdenny wrote:

>




> 2. This patch introduces input annotations for existing diagnostics.  Those diagnostics are enumerated in MatchType in FileCheckDiag in llvm/include/llvm/Support/FileCheck.h.  Would it be helpful to have each patch introduce annotations for one MatchType member?  The first patch would likely be the largest as it would introduce boilerplate.

Unless someone (immediately) says it won't be helpful, I'm going to put some effort into this approach at splitting up the patch.


https://reviews.llvm.org/D52999





More information about the llvm-commits mailing list