[PATCH] D53799: [llvm-size] Reject unknown radix values

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM with the suggested changes in the CHECK command names.



================
Comment at: test/tools/llvm-size/unknown-radix.test:2
+RUN: not llvm-size -radix=foo 2>&1 | FileCheck --check-prefix=CHECK-NOT-NUMERIC %s
+CHECK-NOT-NUMERIC: {{.*}}llvm-size{{(\.EXE|\.exe)?}}: for the -radix option: Cannot find option named 'foo'!
+
----------------
Don't use a CHECK prefix with "NOT" in it, to avoid confusion with the "CHECK-NOT:" FileCheck directive. You don't even need "CHECK" in fact, so you could just label them "NON-NUMERIC" and "NUMERIC" or similar.


Repository:
  rL LLVM

https://reviews.llvm.org/D53799