[PATCH] D53236: [SelectionDAG] swap select_cc operands to enable folding

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 05:36:40 PDT 2018


labrinea added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18326
+
+  if ((Fold || Swap) && TLI.getBooleanContents(N0.getValueType()) ==
+       TargetLowering::ZeroOrOneBooleanContent && (!LegalOperations ||
----------------
Shouldn't `TLI.getBooleanContents(N0.getValueType())` be `TLI.getBooleanContents(getSetCCResultType(N0.getValueType()))` instead, or it doesn't matter?


https://reviews.llvm.org/D53236





More information about the llvm-commits mailing list