[PATCH] D53799: [llvm-size] Reject unknown radix values

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 03:55:33 PDT 2018

Previous message: [PATCH] D53790: [llvm-objcopy] Move elf-specific code into subfolder
Next message: [PATCH] D53799: [llvm-size] Reject unknown radix values
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Code change is fine, but please add a test to show that an unknown value is rejected with a useful error message.


Repository:
  rL LLVM

https://reviews.llvm.org/D53799

Previous message: [PATCH] D53790: [llvm-objcopy] Move elf-specific code into subfolder
Next message: [PATCH] D53799: [llvm-size] Reject unknown radix values
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list