[PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

Marc-Andre Laperle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 28 22:01:20 PDT 2018


malaperle updated this revision to Diff 171451.
malaperle added a comment.

Simply checks

I think those =breakpoint-modified checks are a bit overzealous. The important
check is whether of not we hit the breakpoint in a resolved location,
i.e. not 0xffffffff. So, at the *stopped. The presence and timing of

breakpoint-modified is orthogonal to this patch.
================================================


https://reviews.llvm.org/D52953

Files:
  lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c
  tools/lldb-mi/MICmdCmdBreak.cpp
  tools/lldb-mi/MICmdCmdGdbSet.cpp
  tools/lldb-mi/MICmdCmdGdbSet.h
  tools/lldb-mi/MICmdCmdGdbShow.cpp
  tools/lldb-mi/MICmdCmdGdbShow.h
  tools/lldb-mi/MICmnResources.cpp
  tools/lldb-mi/MICmnResources.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52953.171451.patch
Type: text/x-patch
Size: 10832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181029/f63c23de/attachment.bin>


More information about the llvm-commits mailing list