[PATCH] D53690: [llvm-objdump] Don't Crash When Using `-a` on Non-Archives (PR39402)

Eugene Sharygin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 28 03:15:53 PDT 2018


eush added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:2309
 
   if (ArchiveHeaders && !MachOOpt)
+    printArchiveChild(ArchiveName, c);
----------------
It seems like you could just add `&& c` here and in the second overload and the signature of `printArchiveChild` could stay the same.


https://reviews.llvm.org/D53690





More information about the llvm-commits mailing list