[llvm] r345467 - [utils] collect_and_build_with_pgo.py: revert part already fixed in rL345461

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 27 16:10:10 PDT 2018


Author: maskray
Date: Sat Oct 27 16:10:09 2018
New Revision: 345467

URL: http://llvm.org/viewvc/llvm-project?rev=345467&view=rev
Log:
[utils] collect_and_build_with_pgo.py: revert part already fixed in rL345461

The change was inadvertently included in my last commit.

Modified:
    llvm/trunk/utils/collect_and_build_with_pgo.py

Modified: llvm/trunk/utils/collect_and_build_with_pgo.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/collect_and_build_with_pgo.py?rev=345467&r1=345466&r2=345467&view=diff
==============================================================================
--- llvm/trunk/utils/collect_and_build_with_pgo.py (original)
+++ llvm/trunk/utils/collect_and_build_with_pgo.py Sat Oct 27 16:10:09 2018
@@ -35,6 +35,14 @@ def _run_benchmark(env, out_dir, include
     """The 'benchmark' we run to generate profile data."""
     target_dir = env.output_subdir('instrumentation_run')
 
+    # `check-llvm` and `check-clang` are cheap ways to increase coverage. The
+    # former lets us touch on the non-x86 backends a bit if configured, and the
+    # latter gives us more C to chew on (and will send us through diagnostic
+    # paths a fair amount, though the `if (stuff_is_broken) { diag() ... }`
+    # branches should still heavily be weighted in the not-taken direction,
+    # since we built all of LLVM/etc).
+    _build_things_in(env, out_dir, what=['check-llvm', 'check-clang'])
+
     # Building tblgen gets us coverage; don't skip it. (out_dir may also not
     # have them anyway, but that's less of an issue)
     cmake = _get_cmake_invocation_for_bootstrap_from(
@@ -48,14 +56,6 @@ def _run_benchmark(env, out_dir, include
     # Just build all the things. The more data we have, the better.
     _build_things_in(env, target_dir, what=['all'])
 
-    # `check-llvm` and `check-clang` are cheap ways to increase coverage. The
-    # former lets us touch on the non-x86 backends a bit if configured, and the
-    # latter gives us more C to chew on (and will send us through diagnostic
-    # paths a fair amount, though the `if (stuff_is_broken) { diag() ... }`
-    # branches should still heavily be weighted in the not-taken direction,
-    # since we built all of LLVM/etc).
-    _build_things_in(env, target_dir, what=['check-llvm', 'check-clang'])
-
 ### Script
 
 




More information about the llvm-commits mailing list