[PATCH] D53795: [utils] Fix _run_benchmark in collect_and_build_with_pgo.py

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

LGTM assuming the `_run_benchmark` changes are undone.

Thank you!



================
Comment at: utils/collect_and_build_with_pgo.py:57
+    # since we built all of LLVM/etc).
+    _build_things_in(env, target_dir, what=['check-llvm', 'check-clang'])
 
----------------
Please put this back; it should've been fixed by r345461. The intent was to run this in the instrumented clang's directory for extra coverage. Instrumentation makes the testing phase way slower, but given that this is already four clean builds of clang/llvm anyway, ...

If r345461 doesn't solve the problem you're seeing, more details would be appreciated. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D53795