[PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

[Alexander Polyakov via Phabricator via llvm-commits]

apolyakov added inline comments.


================
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
----------------
As far as your first command is `file-exec-and-symbols`, the best way is to use a generic executable's name. Here it should be:
```
# RUN: %cc -o %t %p/inputs/break-insert-pending.c -g
# RUN: %lldbmi %t < %s | FileCheck %s
```


================
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:9
+
+-file-exec-and-symbols b.exe
+# CHECK: ^done
----------------
It might be removed then.


================
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:20
+-break-insert printf
+#CHECK "^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="\?\?",file="\?\?",fullname="\?\?/\?\?",line="0",pending=\["printf"\],times="0",original-location="printf"}
+#CHECK "=breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="\?\?",file="\?\?",fullname="\?\?/\?\?",line="0",pending=\["printf"\],times="0",original-location="printf"}
----------------
It should be `# CHECK:`, it will not work otherwise.

The same comment for other places.


https://reviews.llvm.org/D52953