[PATCH] D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 27 05:06:29 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D49837#1278151, @ikulagin wrote:

> Changes in this patch require the changes in target specific parts (AArch64, X86, etc), otherwise
>  some tests will fail. Should I include these target specific changes into the current differential or into a separate one?
>  Now they are in separate differential.


Better to merge them all into this patch - reviewers will be able to advise if anything can be cherry picked out then.


Repository:
  rL LLVM

https://reviews.llvm.org/D49837





More information about the llvm-commits mailing list