[PATCH] D49168: [LV] Add a new reduction pattern match

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D49168#1277837, @Carrot wrote:

> This patch doesn't correctly handle isFast(). By default isRecurrenceInstr() should check I->isFast(), but for this pattern I is Select,  isFast() doesn't apply to it, it should be checked against FAdd/FMul inside isConditionalRdxPattern().


Benjamin has said something similar, but I could not reproduce. I'll revert the patch and fix the issue. Thanks for the reproducer case!

--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D49168