[PATCH] D53379: GSYM symbolication format

Greg Clayton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 15:12:47 PDT 2018


clayborg added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/GsymReader.h:46
+struct Header {
+  uint32_t Magic;
+  uint16_t Version;
----------------
With the switch to using BinaryStreamReader this might just work now if I understand the class directly. I switched over to decoding ArrayRefs for AddrOffsets, AddrInfoOffsets and FileEntry in the GsymReader. So this format can be any endian if needed. BinaryStreamReader would make a copy and swap them right?


https://reviews.llvm.org/D53379





More information about the llvm-commits mailing list