[PATCH] D53158: [buildbot, windows] Update the way the visual studio environment is set

[Galina via Phabricator via llvm-commits]

gkistanova added a comment.

Hi Stella,

Please see my notes inline.

Unless you want to do this by yourself, I can prepare this change. I think I have developed a good understanding of what you are after.



================
Comment at: zorg/buildbot/builders/Util.py:26
+        cmd = [VSWHERE_PATH, "-latest", "-property", "installationPath"]
+        vs_path = subprocess.check_output(cmd).strip()
+        vcvars_command = pjoin(vs_path, 'VC', 'Auxiliary', 'Build', 'vcvarsall.bat')
----------------
This thing also would run on the build master, which does not look like what you want.


================
Comment at: zorg/buildbot/builders/Util.py:27
+        vs_path = subprocess.check_output(cmd).strip()
+        vcvars_command = pjoin(vs_path, 'VC', 'Auxiliary', 'Build', 'vcvarsall.bat')
+    else:
----------------
stella.stamenova wrote:
> gkistanova wrote:
> > Please do not use OS specific path handling, as this gets evaluated on the build master. OS build master is running under, and the OS where the build happens are usually different.
> Ok, so this is not the right change then as vswhere needs to run on the OS where the build is going to happen - otherwise, we will not correctly detect the version of visual studio. Is there a way to specify that we want the command to run on the build slave?
You do build a command that would run on the build machine. But the Python script you write to build that command would be running on the build master.

In other words, whatever you put in `vcvars_command` would go to a remote host to execute.


Repository:
  rL LLVM

https://reviews.llvm.org/D53158