[PATCH] D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:5167-5171
+  unsigned numFixed = MFI.getNumFixedObjects();
+  EVT VT = getPointerTy(DAG.getDataLayout());
+  SDLoc DL(Op);
+  if (numFixed) {
+    return DAG.getFrameIndex(-numFixed, VT);
----------------
What invariant are you relying on for fixed objects here? This seems like it could be fragile. Stack protectors and exception handling schemes often introduce new fixed objects. You might want to scan for the first or last parameter or CSR or whatever it is that you're really trying to be relative to.


Repository:
  rL LLVM

https://reviews.llvm.org/D53673