[PATCH] D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Except for the concern about the test, this looks sensible to me. As this adds a new intrinsic in the public IR, I'd prefer if someone else with a bit more experience with these things to approve it as well though - @efriedma?



================
Comment at: test/CodeGen/AArch64/sponentry.ll:22
+
+define dso_local void @foo([24 x i64]*) {
+  %2 = alloca [24 x i64]*, align 8
----------------
Are you sure this actually triggers the fixed object codepath? (This looks a lot like the test example I posted earlier, and that wasn't at least designed to trigger fixed objects.) I think at least a function with varargs has fixed objects.


Repository:
  rL LLVM

https://reviews.llvm.org/D53673