[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D53710#1277482, @probinson wrote:

> In https://reviews.llvm.org/D53710#1277353, @jdenny wrote:
>
> > Why isn't that just CHECK?  Is that a legitimate use case?
>
>
> CHECK-LABEL will complain if it doesn't find a matching string, so the test would fail if the label text does not appear.
>  However, it's not really a proper use of LABEL, and it would be better to have this test just use CHECK.


Make sense.

The only legitimate LABEL-only use case I've imagined so far involves a test case with multiple FileCheck calls with different combinations of FileCheck prefixes.  Some of those combinations might combine LABEL and non-LABEL directives while other combinations have only LABEL directives, which then serve basically as CHECK directives.  However, I don't know that this use case actually exists in practice.


https://reviews.llvm.org/D53710