[PATCH] D53748: [ARM] Fix test inlineasm-X-allocation.ll

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: silviu.baranga, olista01.
Herald added subscribers: chrib, kristof.beyls, eraman, javed.absar.

While working on FileCheck producing better diagnostics in https://reviews.llvm.org/D53710,
I noticed that this test case is broken in a few different ways, and
wanted to check the changes I made (because there are few things I
don't understand here).

The problem was that labels vfp-CHECK and novfp-CHECK where not
checked, so the test wasn't doing anything. Replacing this with just vfp 
and novfp revealed a test failure in the novfp case: it was actually 
producing `vadd.f32 s0, s0, s0` and not using the GPR registers. But I
don't see how we can ever get GPR registers here, thus I don't think
this test makes much sense, and I have just removed it.


https://reviews.llvm.org/D53748

Files:
  test/CodeGen/ARM/inlineasm-X-allocation.ll


Index: test/CodeGen/ARM/inlineasm-X-allocation.ll
===================================================================
--- test/CodeGen/ARM/inlineasm-X-allocation.ll
+++ test/CodeGen/ARM/inlineasm-X-allocation.ll
@@ -1,15 +1,7 @@
-; RUN: llc -mtriple=armv7-none-eabi -mattr=-neon,-vfpv2 %s -o - | FileCheck %s  -check-prefix=novfp
 ; RUN: llc -mtriple=armv7-none-eabi -mattr=+neon %s -float-abi=hard -o - | FileCheck %s -check-prefix=vfp
 
 ; vfp-LABEL: f1
-; vfp-CHECK: vadd.f32 s0, s0, s0
-
-; In the novfp case, the compiler is forced to assign a core register.
-; Although this register class can't be used with the vadd.f32 instruction,
-; the compiler behaved as expected since it is allowed to emit anything.
-
-; novfp-LABEL: f1
-; novfp-CHECK: vadd.f32 r0, r0, r0
+; vfp: vadd.f32 s0, s0, s0
 
 ; This can be generated by a function such as:
 ;  void f1(float f) {asm volatile ("add.f32 $0, $0, $0" : : "X" (f));}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53748.171264.patch
Type: text/x-patch
Size: 922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181026/afdd9982/attachment-0001.bin>