[llvm] r345356 - Revert "[AArch64] Create proper memoperand for multi-vector stores"

Vlad Tsyrklevich via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 19:00:15 PDT 2018


Author: vlad.tsyrklevich
Date: Thu Oct 25 19:00:14 2018
New Revision: 345356

URL: http://llvm.org/viewvc/llvm-project?rev=345356&view=rev
Log:
Revert "[AArch64] Create proper memoperand for multi-vector stores"

This reverts commit r345315, it was causing test failures on
sanitizer-x86_64-linux-fast.

Removed:
    llvm/trunk/test/CodeGen/AArch64/multi-vector-store-size.ll
Modified:
    llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp

Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp?rev=345356&r1=345355&r2=345356&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp Thu Oct 25 19:00:14 2018
@@ -7972,7 +7972,7 @@ bool AArch64TargetLowering::getTgtMemInt
     Info.opc = ISD::INTRINSIC_VOID;
     // Conservatively set memVT to the entire set of vectors stored.
     unsigned NumElts = 0;
-    for (unsigned ArgI = 0, ArgE = I.getNumArgOperands(); ArgI < ArgE; ++ArgI) {
+    for (unsigned ArgI = 1, ArgE = I.getNumArgOperands(); ArgI < ArgE; ++ArgI) {
       Type *ArgTy = I.getArgOperand(ArgI)->getType();
       if (!ArgTy->isVectorTy())
         break;

Removed: llvm/trunk/test/CodeGen/AArch64/multi-vector-store-size.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/multi-vector-store-size.ll?rev=345355&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/multi-vector-store-size.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/multi-vector-store-size.ll (removed)
@@ -1,164 +0,0 @@
-; RUN: llc -mtriple=aarch64-linux-gnu -stop-after=isel < %s | FileCheck %s
-
-declare void @llvm.aarch64.neon.st2.v4f32.p0f32(<4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st3.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st4.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, float*)
-
-declare void @llvm.aarch64.neon.st1x2.v4f32.p0f32(<4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st1x3.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st1x4.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, float*)
-
-declare void @llvm.aarch64.neon.st2lane.v4f32.p0f32(<4 x float>, <4 x float>, i64, float*)
-declare void @llvm.aarch64.neon.st3lane.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, i64, float*)
-declare void @llvm.aarch64.neon.st4lane.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, i64, float*)
-
-define void @addstx(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entire vector is stored.
-  tail call void @llvm.aarch64.neon.st2.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, float* %res)
-; CHECK: ST2Twov4s {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st3.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, float* %res)
-; CHECK: ST3Threev4s {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st4.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, float* %res)
-; CHECK: ST4Fourv4s {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}
-
-define void @addst1x(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entire vector is stored.
-  tail call void @llvm.aarch64.neon.st1x2.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, float* %res)
-; CHECK: ST1Twov4s {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st1x3.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, float* %res)
-; CHECK: ST1Threev4s {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st1x4.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, float* %res)
-; CHECK: ST1Fourv4s {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}
-
-define void @addstxlane(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entire vector is stored.
-  tail call void @llvm.aarch64.neon.st2lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, i64 1, float* %res)
-; CHECK: ST2i32 {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st3lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, i64 1, float* %res)
-; CHECK: ST3i32 {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st4lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, i64 1, float* %res)
-; CHECK: ST4i32 {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}
-; RUN: llc -mtriple=aarch64-linux-gnu -stop-after=isel < %s | FileCheck %s
-
-declare void @llvm.aarch64.neon.st2.v4f32.p0f32(<4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st3.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st4.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, float*)
-
-declare void @llvm.aarch64.neon.st1x2.v4f32.p0f32(<4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st1x3.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, float*)
-declare void @llvm.aarch64.neon.st1x4.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, float*)
-
-declare void @llvm.aarch64.neon.st2lane.v4f32.p0f32(<4 x float>, <4 x float>, i64, float*)
-declare void @llvm.aarch64.neon.st3lane.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, i64, float*)
-declare void @llvm.aarch64.neon.st4lane.v4f32.p0f32(<4 x float>, <4 x float>, <4 x float>, <4 x float>, i64, float*)
-
-define void @addstx(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entiew vector is stored.
-  tail call void @llvm.aarch64.neon.st2.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, float* %res)
-; CHECK: ST2Twov4s {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st3.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, float* %res)
-; CHECK: ST3Threev4s {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st4.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, float* %res)
-; CHECK: ST4Fourv4s {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}
-
-define void @addst1x(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entiew vector is stored.
-  tail call void @llvm.aarch64.neon.st1x2.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, float* %res)
-; CHECK: ST1Twov4s {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st1x3.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, float* %res)
-; CHECK: ST1Threev4s {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st1x4.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, float* %res)
-; CHECK: ST1Fourv4s {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}
-
-define void @addstxlane(float* %res, <4 x float>* %a,  <4 x float>* %b, <4 x float>* %c, <4 x float>* %d) {
-  %al = load <4 x float>, <4 x float>* %a
-  %bl = load <4 x float>, <4 x float>* %b
-  %cl = load <4 x float>, <4 x float>* %c
-  %dl = load <4 x float>, <4 x float>* %d
-
-  %ar = fadd <4 x float> %al, %bl
-  %br = fadd <4 x float> %bl, %cl
-  %cr = fadd <4 x float> %cl, %dl
-  %dr = fadd <4 x float> %dl, %al
-
-; The sizes below are conservative.  AArch64TargetLowering
-; conservatively assumes the entiew vector is stored.
-  tail call void @llvm.aarch64.neon.st2lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, i64 1, float* %res)
-; CHECK: ST2i32 {{.*}} :: (store 32 {{.*}})
-  tail call void @llvm.aarch64.neon.st3lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, i64 1, float* %res)
-; CHECK: ST3i32 {{.*}} :: (store 48 {{.*}})
-  tail call void @llvm.aarch64.neon.st4lane.v4f32.p0f32(<4 x float> %ar, <4 x float> %br, <4 x float> %cr, <4 x float> %dr, i64 1, float* %res)
-; CHECK: ST4i32 {{.*}} :: (store 64 {{.*}})
-
-  ret void
-}




More information about the llvm-commits mailing list