[PATCH] D53669: [ELF] Don't check if symbols in .llvm.call-graph-profile are unorderable

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:694-695
 
-      // The profile from .llvm.call-graph-profile is conceptually affiliated to
-      // FromSec. Don't warn unorderable symbol if FromSym is not absolute
-      // (FromSec isn't null) and the section is discarded
-      // (!FromSec->Repl->Live).
-      //
-      // We also don't want to warn when ToSym is undefined or is in a shared
-      // object (as symbols in shared objects are fixed and unorderable).
-      //
-      // The check used here is more relaxed (no warning if either FromSym or
-      // ToSym is not Defined) for simplicity and there is no compelling reason
-      // to warn on more cases.
-      if (!FromSec || FromSec->Repl->Live) {
-        warnUnorderableSymbol(FromSym);
-        warnUnorderableSymbol(ToSym);
-      }
+      // Don't check if FromSym or ToSym is unorderable. There are too many
+      // reasonable cases that they would be considered unorderable.
       if (FromSec && ToSec)
----------------
I don't think you need to leave any comment. In particular, this comment does not actually give any justification on why you are not doing it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53669