[PATCH] D53727: Only call FlushFileBuffers when writing executables

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 14:07:17 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D53727#1276540, @ruiu wrote:

> Can I ask what was the reason to call FlushFileBuffer on file close in the first place? My understanding is that, if the last open file handler is closed, anything that was written to the file was automatically flushed at the moment. Or, it is not the case?


See the patch description here: https://reviews.llvm.org/D42925


Repository:
  rL LLVM

https://reviews.llvm.org/D53727





More information about the llvm-commits mailing list