[PATCH] D53727: Only call FlushFileBuffers when writing executables

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 13:53:55 PDT 2018


aganea added a comment.

In https://reviews.llvm.org/D53727#1276438, @zturner wrote:

> Bruce Dawson also tells me that Microsoft has fixed this bug in Windows 10 RS5/1810.  Can we additionally disable this workaround entirely behind a runtime OS version check?


Looks like there's no 1810 yet. Redstone 5 is 1809 build 17763.55, as described here <https://pureinfotech.com/windows-10-version-release-history/#windows10_version_1809_insider>. I'll wait for Bruce's answer before adding the test.


Repository:
  rL LLVM

https://reviews.llvm.org/D53727





More information about the llvm-commits mailing list