[PATCH] D53408: [PPC64] Long branch thunks.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 13:48:16 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Symbols.h:85
+  // linkage table (which is only used on PowerPC64).
+  uint32_t LtIndex = -1;
+
----------------
Not sure if this renaming is good. Most people don't know and honestly don't care too much about PPC64 ABI, and PLT is a known terminology for them but LT is perhaps too unfamiliar.

Can you simply add a new member for PowerPC64 Linkage Table index? Does it need a full 32-bit or can it fit in 16 bit?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53408





More information about the llvm-commits mailing list