[PATCH] D53710: [FileCheck] Warn if a prefix is only used in LABEL checks

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

Have you run existing test suites to see how many warnings you get?  That would help to determine if there are use cases we haven't thought of.  If there are no use cases, we might consider making this an error.



================
Comment at: lib/Support/FileCheck.cpp:851
+    SM.PrintMessage(SMLoc::getFromPointer(Buffer.data()),
+                    SourceMgr::DK_Note,
+                    "Prefix " + MatchedPrefix + " only occurs in a LABEL check, "
----------------
Notes usually follow other diagnostics.  Shouldn't this be a warning?


https://reviews.llvm.org/D53710