[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In https://reviews.llvm.org/D45213#1259147, @zturner wrote:

> FWIW, all object files always start with an S_OBJNAME, even if there is no PCH support. But if there is no PCH support, the signature field will just be 0.


Just wanted to point out that it's only true for `cl`-generated OBJs. `clang-cl` does not generate the `S_OBJNAME` record.



================
Comment at: lld/trunk/COFF/PDB.cpp:686
+
+  // Cross-compile warning: given that Clang doesn't generate LF_PRECOMP
+  // records, we assume the OBJ comes from a Windows build of cl.exe. Thusly,
----------------
@zturner I've added this comment.


https://reviews.llvm.org/D45213