[PATCH] D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 18:45:58 PDT 2018


tabloid.adroit created this revision.
Herald added subscribers: Sanitizers, llvm-commits, delcypher, mgorny.

This matches standalone build behavior.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53686

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -375,6 +375,9 @@
 
 if (COMPILER_RT_USE_BUILTINS_LIBRARY)
   list(APPEND SANITIZER_COMMON_LINK_LIBS ${COMPILER_RT_BUILTINS_LIBRARY})
+  if (NOT COMPILER_RT_STANDALONE_BUILD)
+    string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")
+  endif()
 else()
   if (ANDROID)
     append_list_if(COMPILER_RT_HAS_GCC_LIB gcc SANITIZER_COMMON_LINK_LIBS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53686.171031.patch
Type: text/x-patch
Size: 511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181025/7613d5cc/attachment.bin>


More information about the llvm-commits mailing list