[PATCH] D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 18:45:58 PDT 2018


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with the test nit

Would you be willing to rename that `Size` member to `SizeInBits` to make the value clearer?



================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-load-v4s32.mir:5
+# CHECK: Legalize Machine IR for: load_v4s32
+# CHECK-NEXT: G_LOAD
+# CHECK-NOT: Lower
----------------
Could you include the full instruction (with operands and types) in this check?


https://reviews.llvm.org/D53679





More information about the llvm-commits mailing list