[llvm] r344522 - [ADT] Adds equality operators for DenseMap and DenseSet, and an initializer_list

[Lang Hames via llvm-commits]

Actually it looks like this is more widely distributed through ORC than I
remembered. I will install Xcode 8 tomorrow and see if I can reproduce and
then fix this by explicitly declaring the constructors for DenseMapPair.

Cheers,
Lang.

On Wed, Oct 24, 2018 at 4:56 PM Lang Hames <lhames at gmail.com> wrote:

> Hi Marshall,
>
> $ clang --version
>> Apple LLVM version 8.0.0 (clang-800.0.42.1)
>
>
> That is new enough that we need to support it. I will move this code into
> the unit tests where it is used for now.
>
> It sounds like people are talking about moving to c++14 or c++17 next
> year. If that happens we should re-asses: we might be able to move this
> back into DenseMap/DenseSet then. Otherwise we can try to move it back when
> we abandon clang-800 support.
>
> Cheers,
> Lang.
>
> On Wed, Oct 24, 2018 at 9:54 AM Marshall Clow <mclow.lists at gmail.com>
> wrote:
>
>> On Wed, Oct 24, 2018 at 9:14 AM Lang Hames <lhames at gmail.com> wrote:
>>
>>> Hi Dean,
>>>
>>> If Xcode 10.9 is still supported
>>>
>>>
>>> Xcode 10.0 was only just released. Where are you getting the 10.9
>>> version number from?
>>>
>>> The builder that showed this failure was running Xcode 5.1 (released
>>> 2014), which is old enough that I think we could justify killing off
>>> support for it. If this problem is showing up on newer Xcodes then we will
>>> need to deal with it.
>>>
>>
>> I am building with:
>> $ clang --version
>> Apple LLVM version 8.0.0 (clang-800.0.42.1)
>> Target: x86_64-apple-darwin15.6.0
>> Thread model: posix
>> InstalledDir:
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
>>
>>  ls -l
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang*
>> -rwxr-xr-x  1 root  wheel  53002800 Dec  6  2016
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
>> lrwxr-xr-x  1 root  wheel         5 Dec 13  2016
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++
>> -> clang
>>
>> --Marshall
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181024/968444b6/attachment.html>