[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 13:34:56 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D50166#1273097, @efriedma wrote:

> Missing test coverage for SEH_SaveFPLR_X, SEH_SaveReg, SEH_SaveFReg, SEH_SetFP, SEH_AddFP, SEH_Nop, and the alloc_s variant of SEH_StackAlloc.  (I'd like to see at least one use of each opcode to show the encoding is correct/consistent with llvm-readobj.)


I'd also like to see a test for shrink-wrapping. You may have to disable it if you cannot yet describe such prologues it with SEH_ opcodes.


Repository:
  rL LLVM

https://reviews.llvm.org/D50166





More information about the llvm-commits mailing list