[PATCH] D53663: [X86] Add a common-avx512 CPU to match icc's -xCOMMON-AVX512 option

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86.td:874
+]>;
+def : CommonAVX512Proc<"common-avx512">;
+
----------------
greened wrote:
> AVX512F is supposed to be the minimum support needed for common AVX512 functionality.  Instead of "common" throughout, would it make sense to just say "avx512f?"  "common-avx512" isn't a specification that exists anywhere, while "avx512f" is.
This also includes AVX512CD(strangely named FeatureCDI) which both KNL and skylake support and is enabled by the -xCOMMON-AVX512 option in icc. I'm just trying to match that existing feature. I'll admit the name sucks


https://reviews.llvm.org/D53663