[PATCH] D53384: [PowerPC] Make no-PIC default to match GCC - CLANG

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 11:34:06 PDT 2018


jsji added a comment.

Agree, I prefer that we don't set either -fPIC or -fPIE by default .



================
Comment at: test/Driver/ppc-abi.c:33
 // CHECK-ELFv2: "-target-abi" "elfv2"
 
----------------
No sure whether this is correct place to add, but maybe we should add some test to make sure that adding -fPIC option will set the pic-level the same as before?


================
Comment at: test/Driver/print-multi-directory.c:7
 
-// CHECK-X86-MULTILIBS:      32
+// CHECK-X86-MULTILIBS:      .
 // CHECK-X86-MULTILIBS-NOT:  {{^.+$}}
----------------
Do we know why this changes due to fPIC default change?  
If this is a non-relevant change, maybe deliver in another NFC commit? Thanks.


https://reviews.llvm.org/D53384





More information about the llvm-commits mailing list