[PATCH] D53653: [Spectre] Fix MIR verifier errors in retpoline thunks

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 10:56:34 PDT 2018


efriedma added a comment.

> The main challenge here is that X86InstrInfo::AnalyzeBranch doesn't understand the way we're using a CALL instruction as a branch

This seems like something which could be fixed directly by adding a pseudo-instruction to represent the "call". For example, on Thumb1, we have tBfar.  But maybe it's not worth fixing if the only place it would be used is inside retpoline thunks.


https://reviews.llvm.org/D53653





More information about the llvm-commits mailing list