[PATCH] D53407: [llvm-mca] Move namespace mca inside llvm::

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 10:08:43 PDT 2018


MaskRay added a comment.

> I am okay with this change provided that you only change files in llvm-mca/include or in llvm-mca/lib.

Why is the difference between `llvm-mca/include/*` and `llvm-mca/Views/*`?

If `llvm-mca/Views/*` names want to stay in `namespace mca`, as they reference `llvm-mca/include/*`, they need to be written as:

  namespace mca {
  using namespace llvm::mca;

or use qualified `llvm::mca::*` (which is clumsy)

Having both `namespace mca` and `namespace llvm::mca` will make it easy to cause name conflict.


Repository:
  rL LLVM

https://reviews.llvm.org/D53407





More information about the llvm-commits mailing list