[PATCH] D46424: [RISCV] Support .option push and .option pop

[James Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

A couple of minor comments but otherwise looks good to my non-authoritative eyes.



================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:136
+    return false;
+  }
 public:
----------------
Missing blank line after this


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1325
+    if (popFeatureBits())
+      return Error(StartLoc, ".option pop with no .option push");
+
----------------
You use StartLoc here but manually call `Parser.geTok().getLoc()` earlier. Personally I'd just remove StartLoc altogether, it's only required on the error paths and only ever used once on each path.


Repository:
  rL LLVM

https://reviews.llvm.org/D46424