[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 05:10:26 PDT 2018


sbc100 added a comment.

It doesn't seem like a good idea to rely on the string in the assert.  Perhaps adding an error to the asm parser and checking for that would make more sense?

Having said that I don't know why the assert approach wouldn't pass the test assuming assertions are enabled.


Repository:
  rL LLVM

https://reviews.llvm.org/D53620





More information about the llvm-commits mailing list