[PATCH] D53424: Enable thread specific cl::opt values for multi-threaded support

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 04:20:01 PDT 2018


nhaehnle added a comment.

>> - Given that `cl::opt`’s are usually global it feels extremely weird that reading and writing to these could actually be a thread local operation.
> 
> That's purely aesthetic opinion and not an argument at all.

I should add that there are even ways to address these aestethics if people really get hung up over it. You could make it so querying a `cl::opt` value ends up looking something like `cl::getContextValue(NameOfClOptVariable)`.


Repository:
  rL LLVM

https://reviews.llvm.org/D53424





More information about the llvm-commits mailing list