[PATCH] D53424: Enable thread specific cl::opt values for multi-threaded support

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 23 20:26:39 PDT 2018


jfb added a comment.

In https://reviews.llvm.org/D53424#1273716, @yrouban wrote:

> In https://reviews.llvm.org/D53424#1272419, @delcypher wrote:
>
> >
>
>
> This is a very good summary. I would suggest that we land this patch and mark this feature as a temporary solution asking the users to consider moving the options they redefine to the new API https://reviews.llvm.org/D5389.


It would be good to make sure this part of the comment is also addressed:

> However I really don't want to see what's in this patch become permanent unless there is a strong commitment from the community to start cleaning up our global options mess so that this patch can eventually be removed.

Was there a commitment from the community, with some time horizon for moving away from this patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D53424





More information about the llvm-commits mailing list